2007-08-30 C.J. Adams-Collier * bin/xen-create-image (various) - addressed the sev5 issues reported by perlcritic: -- 'use English' was generating vars for regex matches -- subroutines were not returning values -- bareword filehandles were being used -- '>' or ">" becomes q{>} -- 'return' does the same as 'return undef' (global) - log message and exit if readConfigurationFile() fails - log message and exit if checkSystem() fails - created a %string global to store translatable strings (checkSystem) - wrapped long lines to max 80 chars - moved shell missing error to %string - made the valid shell list a bit more extensible (testXenConfig) - named the sxp fh line iterator - placed if( ... ) { curly braces as per /usr/src/linux-2.6-2.6.18.dfsg.1/Documentation/CodingStyle - moved error strings to %string - return 1 on success (setupDefaultOptions) - creating a local variable named %CONFIG and returning it (readConfigurationFile) - replaced 'if ( ! foo )' with 'unless foo' - moved definition of $line into the scope in which it is used - return 1 on success (parseCommandLineArguments) - re-ordered the *-cmd options for clarity - return 1 on success (checkArguments) - moved error strings to %strings - cleaned up partitionsdir check