[xen-tools-discuss] [xen-shell] [PATCH] fix open command for xm list

Hi all,
It seems the open commands used in isRunning and do_status don't work as
expected on recent versions of perl. This was observed on 

  This is perl, v5.8.7 built for x86_64-linux-gnu-thread-multi

as well as

  This is perl, v5.8.8 built for x86_64-linux-gnu-thread-multi

on Ubuntu Dapper and Hardy, respectively.

Specifically, the problem appears to be with the pipe passed as the last
argument in the @cmd variable.

Perl doesn't seem to like that pipe there ('Bad command or file name' error),
which results in the 'status' command always returning 'Shutdown', regardless
of the real status of the guest.

The perlfunction man page on the 'open' command suggests

  For three or more arguments if MODE is '|-', the filename is interpreted as
  a command to which output is to be piped, and if MODE is '-|', the filename
  is interpreted as a command which pipes output to us. 

which works when used in the arguments to the open call but not when simply
added to the front of @cmd (tainting?). The attached patch implements the fix
to make the status command work.

Thanks,
Ward.

-- 
Pong.be         -(   "If you think penguins are fat and waddle, you have   )-
Virtual hosting -( never been attacked by one running at you in excess of  )-
http://pong.be  -(                   100 MPH." -- Linus                    )-
GnuPG public key: http://pgp.mit.edu